Add __async: auto decorator
#26019
Open
Add __async: auto decorator
#26019
+48
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
reviewed
Dec 30, 2025
| } | ||
|
|
||
| const isAsyncFunction = LibraryManager.library[symbol + '__async']; | ||
| if (ASYNCIFY && isAsyncFunction == 'auto') { |
Collaborator
There was a problem hiding this comment.
For JSPI, I don't think we even need the handleAsync. Though there still may be some issues with balanced runtimeKeepalivePush runtimeKeepalivePop. Maybe worth a try?
Collaborator
Author
There was a problem hiding this comment.
Yes, I think handleAsync is used to keep the runtime alive using runtimeKeepalivePush which I think this currently important. We can look at further simplification are followups perhaps, but for now I'd rather leave the semantics as matching.
This decorator automatically generates the Asyncify.handleAsync wrapper code. Hopefully we can transition all out `__async` functions soon and just make this the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decorator automatically generates the Asyncify.handleAsync wrapper code. Hopefully we can transition all out
__asyncfunctions soon and just make this the default.