Improve automatic symbol pairing for functions with compiler-generated names #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of symbols is not necessarily sorted by address, so if there are multiple `__arraydtor$1234` functions it's possible that they're in reverse order on the right, which would cause them to be paired up incorrectly. To fix this we sort by section index and symbol address after filtering down the list of symbols to ones that have matching names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements for automatically pairing up functions with weird symbol names. MWCC can output symbols in a different order from their actual address order, so they're now internally sorted to handle the case of a single TU having multiple functions with different discriminators so they don't get swapped during pairing.
Before:
After:
And discriminators in the middle of anonymous class names like
__dt__Q29dCamera_c23@class$3665d_camera_cppFvare now also ignored, in addition to the ones at the end of the symbol which were already ignored.Fixes #266