Combine .init sections separately from .text sections #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Combine text sections" option currently has a bug where it will combine all sections into one named ".text", even the ones that were originally named ".init". This causes issues for the
__startTU, making it never show as 100% matched even when it is: https://decomp.dev/zeldaret/tp?unit=framework%2Fdolphin%2Fos%2F__start (This option is enabled by default for report generation, so this affects all projects with text sections not named ".text".)This PR copies the data combine logic so that ".init" and ".text" get combined separately from one another.
Before:
After: