Items in the footer are aligned better than before #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jf-kelly
requested review from
a team,
davidjonesma,
jdones01 and
r-maradiaga
and removed request for
a team
jf-kelly
added
Frontend
Contributor
|
@jf-kelly The left definitely does look better than what's in dev currently. Is there a way to make the copyright and privacy policy + terms of service buttons more similar to production? In production, it looks like the privacy policy and terms of service buttons are aligned left while the copyright is aligned at the center. In dev and in your PR, it seems like the privacy policy and terms of service buttons are still a little to the left. |
Contributor
Author
|
I added another commit that makes everything aligned a little better once again. The Bootstrap update changed certain things, like 'left' and 'right' are now 'start' and 'end', so it would possibly be worth looking into these changes to see if more has broken than we expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with the items in the footer not being aligned properly. I simply removed the 'list-inline' property in the Footer.js file, and the items are more spread out.
This fix does not look exactly like it did before, but it does spread the items out a bit and looks better than what we currently have in dev.
Preview
Related Issue
#611