Consistently treat default parameter values from the CloudFormation template as strings #394
+63
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
force-pushed
the
default-parameter-value-string
branch
from
21e5497 to
4eedc3e
Compare
…emplate as strings
orien
force-pushed
the
default-parameter-value-string
branch
from
4eedc3e to
203aabb
Compare
simpson-ross
approved these changes
Dec 19, 2025
Contributor
simpson-ross
left a comment
simpson-ross
left a comment
There was a problem hiding this comment.
It's frustrating that CloudFormation doesn't use the defined type of the parameter for that parameter's default value, but here we are. It'd be interesting to know what happens for more complex types that can't be meaningfully coerced into strings (like a list).
In any case, suppressing that false-positive diff output is a good outcome, so 👍, and thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When default parameter values from the CloudFormation template are used, CloudFormation records them as
strings. When StackMaster loads the default value from the template to present a diff, it uses the type as defined in the template:string,integer,boolean, orfloat. If the type doesn't match that stored in CloudFormation state, StackMaster erroneously thinks there's a change and presents a diff to the user. E.g.,Change
Avoid this problem by treating default parameter values in a manner consistent with CloudFormation: as
strings.