RuboCop: resolve Style/* issues

CHANGELOG.md

@@ -10,7 +10,12 @@ The format is based on [Keep a Changelog], and this project adheres to
 
 ## [Unreleased]
 
+### Changed
+
+- Resolve style issues identified by RuboCop ([#396])
+
 [Unreleased]: https://github.com/envato/stack_master/compare/v2.17.1...HEAD
+[#396]: https://github.com/envato/stack_master/pull/396
 
 ## [2.17.1] - 2025-12-19
 

Rakefile

@@ -1,11 +1,11 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'bundler/setup'
 
 task :environment do
   require 'stack_master'
 end
 
-task :console => :environment do
+task console: :environment do
   require 'pry'
   binding.pry
 end
@@ -19,12 +19,12 @@ begin
 
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec) do |t|
-    t.rspec_opts = "--format doc"
+    t.rspec_opts = '--format doc'
   end
 
   require 'rubocop/rake_task'
   RuboCop::RakeTask.new('rubocop')
 rescue LoadError
 end
 
-task :default => [:features, :spec, :rubocop]
+task default: %i[features spec rubocop]

bin/stack_master

@@ -2,14 +2,12 @@
 
 require 'stack_master'
 
-if ENV['STUB_AWS'] == 'true'
-  require 'stack_master/testing'
-end
+require 'stack_master/testing' if ENV['STUB_AWS'] == 'true'
 
-trap("SIGINT") { raise StackMaster::CtrlC }
+trap('SIGINT') { raise StackMaster::CtrlC }
 
 begin
   StackMaster::CLI.new(ARGV.dup).execute!
 rescue StackMaster::CtrlC
-  StackMaster.stdout.puts "Exiting..."
+  StackMaster.stdout.puts 'Exiting...'
 end

example/simple/templates/myapp_vpc.rb

@@ -1,5 +1,5 @@
 SparkleFormation.new(:myapp_vpc) do
-  description "A test VPC template"
+  description 'A test VPC template'
 
   resources.vpc do
     type 'AWS::EC2::VPC'

example/simple/templates/myapp_web.rb

@@ -1,5 +1,5 @@
 SparkleFormation.new(:myapp_web) do
-  description "Test web template"
+  description 'Test web template'
 
   parameters.vpc_id do
     description 'VPC ID'

features/step_definitions/parameter_store_steps.rb

@@ -6,7 +6,7 @@
         parameter: {
           name: parameter_name,
           value: parameter_value,
-          type: "SecureString",
+          type: 'SecureString',
           version: 1
         }
       }

features/step_definitions/stack_steps.rb

@@ -21,20 +21,18 @@
 end
 
 def extract_hash_from_kv_string(string)
-  string.to_s.split(',').inject({}) do |hash, kv|
+  string.to_s.split(',').each_with_object({}) do |kv, hash|
     key, value = kv.split('=')
     hash[key] = value
-    hash
   end
 end
 
 Given(/^I stub the following stacks:$/) do |table|
   table.hashes.each do |row|
     row.symbolize_keys!
     row[:parameters] = StackMaster::Utils.hash_to_aws_parameters(extract_hash_from_kv_string(row[:parameters]))
-    outputs = extract_hash_from_kv_string(row[:outputs]).inject([]) do |array, (k, v)|
+    outputs = extract_hash_from_kv_string(row[:outputs]).each_with_object([]) do |(k, v), array|
       array << OpenStruct.new(output_key: k, output_value: v)
-      array
     end
     row[:outputs] = outputs
     StackMaster.cloud_formation_driver.add_stack(row)

features/support/env.rb

@@ -22,5 +22,5 @@
   Timecop.return
 end
 
-lib = File.join(File.dirname(__FILE__), "../../spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib")
+lib = File.join(File.dirname(__FILE__), '../../spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib')
 $LOAD_PATH << lib

lib/stack_master.rb

@@ -172,7 +172,7 @@ def skip_account_check?
   @non_interactive_answer = 'y'
 
   def base_dir
-    File.expand_path(File.join(File.dirname(__FILE__), ".."))
+    File.expand_path(File.join(File.dirname(__FILE__), '..'))
   end
 
   def cloud_formation_driver

lib/stack_master/aws_driver/cloud_formation.rb

@@ -8,10 +8,10 @@ def region
       end
 
       def set_region(value)
-        if region != value
-          @region = value
-          @cf = nil
-        end
+        return if region == value
+
+        @region = value
+        @cf = nil
       end
 
       def_delegators(

lib/stack_master/aws_driver/s3.rb

@@ -24,19 +24,19 @@ def upload_files(bucket: nil, prefix: nil, region: nil, files: {})
             prefix: prefix,
             bucket: bucket
           }
-        ).map(&:contents).flatten.inject({}) { |h, obj|
+        ).map(&:contents).flatten.inject({}) do |h, obj|
           h.merge(obj.key => obj)
-        }
+        end
 
-        StackMaster.stdout.puts "Uploading files to S3:"
+        StackMaster.stdout.puts 'Uploading files to S3:'
 
         files.each do |template, file|
           body = file.fetch(:body)
           path = file.fetch(:path)
           object_key = template.dup
           object_key.prepend("#{prefix}/") if prefix
           compiled_template_md5 = Digest::MD5.hexdigest(body).to_s
-          s3_md5 = current_objects[object_key] ? current_objects[object_key].etag.gsub("\"", '') : nil
+          s3_md5 = current_objects[object_key] ? current_objects[object_key].etag.gsub('"', '') : nil
 
           next if compiled_template_md5 == s3_md5
 
@@ -51,14 +51,14 @@ def upload_files(bucket: nil, prefix: nil, region: nil, files: {})
               metadata: { md5: compiled_template_md5 }
             }
           )
-          StackMaster.stdout.puts "done."
+          StackMaster.stdout.puts 'done.'
         end
       end
 
       def url(bucket:, prefix:, region:, template:)
         if region == 'us-east-1'
-          ["https://s3.amazonaws.com", bucket, prefix, template].compact.join('/')
-        elsif region.start_with? "cn-"
+          ['https://s3.amazonaws.com', bucket, prefix, template].compact.join('/')
+        elsif region.start_with? 'cn-'
           ["https://s3.#{region}.amazonaws.com.cn", bucket, prefix, template].compact.join('/')
         else
           ["https://s3-#{region}.amazonaws.com", bucket, prefix, template].compact.join('/')

lib/stack_master/change_set.rb

@@ -1,9 +1,9 @@
 module StackMaster
   class ChangeSet
-    END_STATES = [
-      'CREATE_COMPLETE',
-      'DELETE_COMPLETE',
-      'FAILED'
+    END_STATES = %w[
+      CREATE_COMPLETE
+      DELETE_COMPLETE
+      FAILED
     ]
 
     def self.generate_change_set_name(stack_name)
@@ -50,7 +50,7 @@ def display(io)
       @response.changes.each do |change|
         display_resource_change(io, change.resource_change)
       end
-      io.puts "========================================"
+      io.puts '========================================'
     end
 
     def failed?
@@ -84,13 +84,9 @@ def display_resource_change(io, resource_change)
     def display_resource_change_detail(io, action_name, color, detail)
       target_name = [detail.target.attribute, detail.target.name].compact.join('.')
       detail_messages = [target_name]
-      if action_name == 'Replace'
-        detail_messages << "#{detail.target.requires_recreation} requires recreation"
-      end
+      detail_messages << "#{detail.target.requires_recreation} requires recreation" if action_name == 'Replace'
       triggered_by = [detail.change_source, detail.causing_entity].compact.join('.')
-      if detail.evaluation != 'Static'
-        triggered_by << "(#{detail.evaluation})"
-      end
+      triggered_by << "(#{detail.evaluation})" if detail.evaluation != 'Static'
       detail_messages << "Triggered by: #{triggered_by}"
       io.puts Rainbow("- #{detail_messages.join('. ')}. ").color(color)
     end