feat: generate commands for all services defined in equinix-sdk-go #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
force-pushed
the
run-generate-all
branch
from
5afc4b6 to
cb6b418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This onboards all services defined in
equinix-sdk-goto this CLI by running:make generate-allto generate command codemake docsto generate updated docs for the new commandsmake fixto address linter issues in the generated codeA couple of linter issues were caused by incorrect or unnecessary whitespace in the template files, so I addressed those directly in the template. The remaining linter issues were due to import ordering; while we could potentially avoid that issue as well by switching to a more powerful templating system, I think it's fine for now if people/bots have to run
make fixto automatically address linter issues in generated code.