Integration Specs

[odhiambo-ed]

In this PR

n + 1

• Make sure that the N+1 problem is solved when fetching all posts and their comments for a user.
• Integration specs

Use Capybara to write integration tests for each view in your project.

• User index page:

  • I can see the username of all other users.
  • I can see the profile picture for each user.
  • I can see the number of posts each user has written.
  • When I click on a user, I am redirected to that user's show page.

• user show page:

  • I can see the user's profile picture.
  • I can see the user's username.
  • I can see the number of posts the user has written.
  • I can see the user's bio.

• User post index page:

  • I can see the user's profile picture.
  • I can see the user's username.
  • I can see the number of posts the user has written.
  • I can see a post's title.
  • I can see some of the post's body.
  • I can see the first comments on a post.

• Post show page:

  • I can see the post's title.
  • I can see who wrote the post.
  • I can see how many comments it has.
  • I can see how many likes it has.
  • I can see the post body.
  • I can see the username of each commenter.
  • I can see the comment each commentor left.
  • I can see how many comments a post has.
  • I can see how many likes a post has.
  • I can see a section for pagination if there are more posts than fit on the view.
  • When I click on a post, it redirects me to that post's show page.
  • I can see the user's first 3 posts.
  • I can see a button that lets me view all of a user's posts.
  • When I click a user's post, it redirects me to that post's show page.
  • When I click to see all posts, it redirects me to the user's post's index page.

[arslanbisharat]

Hi @white3d & @evans22j,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that doesn't have a first review present.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

Invalid Code Review Request does not count into the code reviews limit.

[odhiambo-ed]

Hi @arslanbisharat,
Kindly elaborate on this statement, "You have submitted a project, that doesn't have a first review present." I don't understand what you mean? Thank you.

[addod19]

Hi @white3d,

Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

• Nice attempt 👍

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[addod19]

• It would be better if we write test for the Users Index page to test for Tests that redirects to the user's show page when you click on a user.

Note:

I find it strange that there is no file change for a project you are suppose to work on ie. Integration specs for view and only see a file change for a README, this could be the reason why the other code reviewer invalidated your project

[odhiambo-ed]

Hi @addod19 ,
The previous reviewer just commented about the wrong pull request. Thank you for your concern.

[addod19]

• It would be better if we write the redirect test for our User Show page as shown in the screenshot below

[addod19]

• It would be better if we write featured test for our User post index page as show in the screenshot below

[odhiambo-ed]

Hello @addod19 ,
I have include all the test state in the picture above. See this please code

[addod19]

• It would be better if we implement test for User post show page as show in the screenshot below

[odhiambo-ed]

Hello @addod19 ,
I have include all the test state in the picture above. See this please code

[Deepakdanger]

Hi @white3d,

Status: Approved ✔️

Your project is complete! All tests are passing. There is nothing else to say other than... it's time to merge it 🚢
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.