Fix: Handle stale executionContext after breakpoint/alert interruption #35418
Conversation
This fixes an issue where React throws 'Should not already be working' error after execution is paused by breakpoint or alert in Firefox. The problem occurs when executionContext is set but workInProgressRoot is null, indicating the context is stale from a previous interrupted render/commit. Instead of throwing, we now reset the stale context. Changes: - Added defensive check in performWorkOnRoot to reset stale executionContext - Added defensive check in commitRoot to reset stale executionContext - Added tests to verify the fix works correctly Test plan: - All tests pass - Verified executionContext is properly reset after interruption - Verified invariant is still enforced when actually working
|
Hi @hassanzadeh-mj! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
hassanzadeh-mj
changed the title
hassanzadeh-mj
changed the title
hassanzadeh-mj
changed the title
hassanzadeh-mj
changed the title
1 participant
Fixes #17355
This fixes an issue where React throws 'Should not already be working' error after execution is paused by breakpoint or alert in Firefox.
The problem occurs when executionContext is set but workInProgressRoot is null, indicating the context is stale from a previous interrupted render/commit. Instead of throwing, we now reset the stale context.
Changes:
Test plan:
Summary
How did you test this change?