[compiler] Fix setState-in-effect for React.useEffect namespace calls (#35377) #35419
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…facebook#35377) ValidateNoSetStateInEffects treats MethodCall.property as the hook callee (so React.useEffect is detected).\n\nAdds a regression fixture for import * as React with React.useState/React.useEffect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix react-hooks/set-state-in-effect false negatives when Hooks are called via a namespace import (e.g.
import * as React from 'react'andReact.useEffect(...)). The validation now checks the MethodCall property (the actual hook function) instead of the receiver object.Issue: Bug: #35377
How did you test this change?
Added a regression fixture;
Ran tests and verified it reports
EffectSetStateand matches the expected output.