Skip to content

Conversation

@tworedz
Copy link

@tworedz tworedz commented May 16, 2025

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

  • Fixed / added type annotations mostly for StreamT class.
  • Fixed generic argument for EventT class.
  • Make sure that App.commit accepts None as a documentation saying (https://faust-streaming.github.io/faust/reference/faust.app.html#faust.app.App.commit)
  • Removed __iter__/__aiter__ methods on StreamT. And it makes sense, because it is extending AsyncIterable, which already implements __aiter__. __iter__ was just redundant here and broke typing.

@tworedz
Copy link
Author

tworedz commented May 16, 2025

please review @wbarnha

@codecov
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (ff75c0b) to head (a44deff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files         102      102           
  Lines       11100    11100           
  Branches     1196     1196           
=======================================
  Hits        10444    10444           
  Misses        557      557           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Most of the changes look good for merge, I am a bit surprised that TPorTopicSet was not already annotated with Optional. I will look closer at the code to make sure this is proper.

@tworedz
Copy link
Author

tworedz commented Jul 18, 2025

Thanks! Seems that pypy doesn't like my changes, btw. Is it because of me or they were failing before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants