Fixes failing note endpoint tests #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects assertions in note endpoint tests to accurately reflect expected behavior. Addresses issues where the test expected a `ReadingNote` object instead of a `Note` object after the type renaming. Also removes a redundant non-null assertion as the subsequent `BeEmpty()` assertion already implies a non-null value. Fixes #83
Introduces unit tests for domain models, including: - `ContainsPlaceholderAttribute` - `NoteCategories` - `Note` - `PostSuggestion` - `ReadingNote` - `SearchCriterias` These tests cover various aspects of the domain models, such as validation, serialization/deserialization, and property setting. The old `NoteTests` and `ReadingNoteTests` files were deleted since they were duplicated. The goal is to ensure the correctness and reliability of the core domain logic.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects assertions in note endpoint tests to accurately reflect expected behavior.
Addresses issues where the test expected a
ReadingNoteobject instead of aNoteobject after the type renaming.Also removes a redundant non-null assertion as the subsequent
BeEmpty()assertion already implies a non-null value.Fixes #83