fix: block macro speedup
#292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds build.rs which makes phf map allowing to speed up the calculation of the blockid
this commit adds placeholder feature and restructures the parsing to allow _ and ident in property's value.
this follows Struct patterns more closely
updates phf to 0.13 and makes block makro use workspace version
lexeyOK
force-pushed
the
fix/clean-block-macro-speedup
branch
from
9123abb to
39ceafc
Compare
updates phf to 0.13 and makes block makro use workspace version
ReCore-sys
reviewed
Dec 9, 2025
| use ferrumc_macros::block; | ||
| #[derive(Debug, PartialEq, Eq)] | ||
| struct BlockStateId(u32); | ||
| #[cfg(false)] |
Contributor
Author
There was a problem hiding this comment.
this was a test what uses all blockstates but you said i shouldn't add it since it's too long to compile, it's useful for me to check itacro is working but it also generates a lot of unnecessary functions so I disable it completely
| /// If the block or properties are invalid, a compile-time error will be thrown that should hopefully | ||
| /// explain the issue. | ||
| /// # Static block | ||
| /// gives a single block pat. Mainly used with |
Collaborator
There was a problem hiding this comment.
Could you add some examples with what you mean by this?
Contributor
Author
There was a problem hiding this comment.
i guess it's showing the distinction between having block with and without properties, if it has any properties they must be used or skiped explicitly, similar to how mattern matching works on structs I don't really know what to write here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds optimisations and syntax improvements for the
block!macro