feat: Structured Components #295
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of (some) Structured Components in InventorySlot.
Client no longer crashes from creative menu items.
Todo:
I HAD TO MODIFY THE `test_slot_encode_decode_roundtrip` DUE TO ASYMMETRIC PROTOCOL FOR COMPONENTS
When decoding client data, the client sends an extra byte after the component ID.
What the client sends:
where
However, when sending data to client, it is expected to be encoded exactly as documented:
If the length byte is included in server to client packets, the client crashes with a decoding error.
But the test expects the protocol to be symmetric (tests object -> bytes -> object), so it crashes when it tries to read more bytes than are available.