Skip to content

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Dec 28, 2025

I’ve experimented with some performance optimizations. Feel free to have a critical view. :)

  • merged pagefind implementations, because we already overwrite an large part of it. Copilot helped me to reorder the file.
  • there was an issue regarding our fonts, which weren’t loaded with font-swap. So i’ve added it and Metric Overrides to avoid layout shifts
  • the hero-image wasn’t loaded with fetchpriority=high
  • there was an issue with chaining critital requests. I’ve added the defer property to the js.

@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@therobrob therobrob added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Dec 28, 2025
@netlify
Copy link

netlify bot commented Dec 28, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit b5f7174
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/69600cfe28eb5a0008533913
😎 Deploy Preview https://deploy-preview-551--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob
Copy link
Member Author

Unfortunately, there is an error: Uncaught ReferenceError: PagefindUI is not defined.

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort to merge the pagefind styles 🚀
It's great if we no longer have to load thepagefind-ui CSS file :)
Unfortunately, there are a few styling issues when I run it locally, not sure if it's just my local preview that has those issues. I added comments for each issue that I found, sorry for the amount 😅

MoritzWeber0
MoritzWeber0 previously approved these changes Jan 3, 2026
@MoritzWeber0 MoritzWeber0 dismissed their stale review January 3, 2026 22:07

Wanted to approve the other PR, I should get some sleep xD

@therobrob therobrob self-assigned this Jan 4, 2026
@therobrob therobrob requested a review from MoritzWeber0 January 8, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants