-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat: performance optimizations #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Unfortunately, there is an error: Uncaught ReferenceError: PagefindUI is not defined. |
MoritzWeber0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort to merge the pagefind styles 🚀
It's great if we no longer have to load thepagefind-ui CSS file :)
Unfortunately, there are a few styling issues when I run it locally, not sure if it's just my local preview that has those issues. I added comments for each issue that I found, sorry for the amount 😅
Wanted to approve the other PR, I should get some sleep xD
I’ve experimented with some performance optimizations. Feel free to have a critical view. :)
fetchpriority=high