Updating to typescript 5

[joehan]

Description

Updating the repo to use Typescript 5. This is a bit overdue anyway, and was necessary to get us off of a vulnerable version of @modelcontextprotocol/sdk

Scenarios Tested

npm i && npm run build && npm run test passes.

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant upgrade of the project's TypeScript version to 5.3.3, alongside updating several related dependencies. This update necessitated various code adjustments to comply with the new, stricter type checking rules and to ensure compatibility. Additionally, the project's compilation target has been moved to es2020, enabling the use of more contemporary JavaScript syntax. The changes aim to improve code robustness, maintainability, and leverage the latest features offered by TypeScript.

Highlights

• TypeScript Version Upgrade: The project's TypeScript dependency has been updated from version 4.5.4 to 5.3.3, bringing the codebase up to date with the latest language features and stricter type checking.
• Dependency Updates: Key dependencies including @types/node and @modelcontextprotocol/sdk have been updated to their latest compatible versions to support the TypeScript upgrade and leverage new functionalities.
• Type-Safety Enhancements and Adjustments: Several code modifications were made to accommodate TypeScript 5's stricter type checking, including explicit type assertions (as any, as unknown as T), safer property access checks ('text' in c ? c.text : ''), and corrections in typeof checks.
• ECMAScript Target Update: The tsconfig.json file has been updated to target es2020, allowing the compiled JavaScript to utilize more modern ECMAScript features.
• Minor Logic Refinement: A small change in src/emulator/auth/state.ts modifies the default behavior for oneAccountPerEmail by removing a nullish coalescing operator, potentially altering how duplicate email settings are handled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the repository to use TypeScript 5. The changes mostly consist of dependency updates in package.json and tsconfig.json, along with code adjustments to satisfy TypeScript 5's stricter type checking. While many changes are correct fixes for new type errors, I've noticed a pattern of using as any to suppress compiler errors in several files, particularly in tests and MCP tools. This bypasses type safety and can hide underlying bugs. I've left comments suggesting safer alternatives, such as using more specific type assertions or type guards, similar to the good practice seen in src/mcp/tools/core/read_resources.ts.

[joehan]

Unrelated to this change - this test has been failing and web frameworks on Windows is a low enough priority that I can't justify spending more time to fix it. AFAICT from a quick deploy on my windows cloud top, the flow still works, so I'll wait for a issue report to prioritize this.