-
Notifications
You must be signed in to change notification settings - Fork 630
feat(genkit-tools): add /listValues endpoint to expose defaultModel
#4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ssbushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new API endpoint and associated functionality within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new /listValues endpoint to expose values from the registry. The changes are mostly correct, but I've identified a bug in the client-side request construction within RuntimeManager and a minor issue with error handling on the server-side. My review includes specific suggestions to address these points for improved correctness and robustness.
| 'ID of the Genkit runtime to run the action on. Typically $pid-$port.' | ||
| ), | ||
| type: z | ||
| .enum(['defaultModel']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restricted to defaultModel only.
| 'defaultModel', | ||
| 'defaultModel', | ||
| this.options.model | ||
| modelName(this.options.model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized that having the conversion done at registry time is more convenient, since all types needed are available here. WDYT?
| type: input.type, | ||
| }, | ||
| }) | ||
| .catch((err) => this.httpErrorHandler(err, 'Error listing values.')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backwards compatibility consideration -- Go and python won't have this endpoint implemented, so will be getting 404. Should 404 be handled here and an empty record returned, or bubble up the error all the way to the Dev UI and let it deal with backwards compatibility?
I'm leaning towards handle 404 here...
Checklist (if applicable):