Skip to content

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jan 5, 2026

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ssbushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new API endpoint and associated functionality within the genkit-tools to allow for the retrieval of various runtime-specific values. This enhancement provides a standardized way to query and expose internal Genkit data, such as defaultModel (implied by the title, though the code uses a generic type parameter), making it more accessible for tooling and introspection.

Highlights

  • New /listValues Endpoint: A new /listValues endpoint has been introduced in genkit-tools to retrieve various runtime-specific values, enhancing the ability to inspect Genkit application states.
  • RuntimeManager Enhancement: The RuntimeManager now includes a listValues method, responsible for orchestrating the fetching of values from the reflection server, handling runtime selection and potential errors.
  • API Schema Definition: A new ListValuesRequestSchema and corresponding type have been defined, standardizing the input for the new endpoint, which requires a type parameter and optionally accepts a runtimeId.
  • ReflectionServer Integration: The ReflectionServer now exposes a /api/values GET endpoint, allowing clients to query for specific types of values, such as defaultModel, by providing a type query parameter.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new /listValues endpoint to expose values from the registry. The changes are mostly correct, but I've identified a bug in the client-side request construction within RuntimeManager and a minor issue with error handling on the server-side. My review includes specific suggestions to address these points for improved correctness and robustness.

'ID of the Genkit runtime to run the action on. Typically $pid-$port.'
),
type: z
.enum(['defaultModel'])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restricted to defaultModel only.

'defaultModel',
'defaultModel',
this.options.model
modelName(this.options.model)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized that having the conversion done at registry time is more convenient, since all types needed are available here. WDYT?

type: input.type,
},
})
.catch((err) => this.httpErrorHandler(err, 'Error listing values.'));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards compatibility consideration -- Go and python won't have this endpoint implemented, so will be getting 404. Should 404 be handled here and an empty record returned, or bubble up the error all the way to the Dev UI and let it deal with backwards compatibility?

I'm leaning towards handle 404 here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants