Skip to content

fix: update python banner image URL in README #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twangodev merged 1 commit into from
Dec 16, 2025
Merged

fix: update python banner image URL in README #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
![python.png](.github/assets/python.png)
![python.png](https://raw.githubusercontent.com/fishaudio/fish-audio-python/refs/heads/main/.github/assets/python.png)
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The absolute URL hardcodes the branch name 'main' in the path. This approach has maintainability concerns:

  1. If someone views this README from a different branch, they'll still see the image from the main branch, which could be confusing during development
  2. The relative path approach is more flexible and follows GitHub best practices for README files

Consider reverting to the relative path, or if an absolute URL is necessary for external viewing (e.g., on PyPI), consider using a URL without the branch reference, such as using a release tag or the default branch shorthand.

Suggested change
![python.png](https://raw.githubusercontent.com/fishaudio/fish-audio-python/refs/heads/main/.github/assets/python.png)
![python.png](.github/assets/python.png)

Copilot uses AI. Check for mistakes.

# Fish Audio Python SDK

Expand Down