Fix: Critical cache key collision bug in ApiModelCache #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in cache key Previously, generateQueryCacheKey() only included a hardcoded whitelist of 11 parameters, causing cache key collisions when different filter values were used (e.g., type=customer vs type=contact generated the same cache key). This fix includes ALL query parameters in the cache key generation, excluding only internal/cache-busting parameters like '_', 'timestamp', 'nocache', and '_method'. Impact: - Fixes data integrity issue where different queries returned cached results from other queries - Ensures accurate cache HIT/MISS behavior for all filter combinations - Backward compatible - existing cache keys will naturally expire and regenerate Example: Before: /contacts?type=customer and /contacts?type=contact had SAME cache key After: /contacts?type=customer and /contacts?type=contact have DIFFERENT cache keys
Fix: Critical cache key collision bug in ApiModelCache
…t SoftDeletes Issue: shouldQualifyColumn() method was unconditionally calling getDeletedAtColumn() which only exists on models using the SoftDeletes trait. This caused a fatal error when querying models like Permission that don't use soft deletes. Error: BadMethodCallException: Call to undefined method Fleetbase\Models\Permission::getDeletedAtColumn() Fix: Check if the method exists before calling it using method_exists(). Only include deleted_at column in qualifiable columns if the model uses SoftDeletes. Impact: - Fixes fatal error when querying Permission and other non-soft-deletable models - Maintains backward compatibility with models that do use SoftDeletes - No functional changes to soft-delete behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
type=customervstype=contact) now generate unique cache keys instead of returning wrong cached resultsgetDeletedAtColumn()Improvements