-
-
Notifications
You must be signed in to change notification settings - Fork 466
Add profiling to more samples, add E2E Tests #4969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Add profiling to more samples, add E2E Tests ([#4969](https://github.com/getsentry/sentry-java/pull/4969))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5b66efd | 308.67 ms | 363.85 ms | 55.18 ms |
| fc5ccaf | 322.49 ms | 405.25 ms | 82.76 ms |
| 6405ec5 | 310.88 ms | 354.56 ms | 43.69 ms |
| d364ace | 382.77 ms | 443.21 ms | 60.44 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| 539ca63 | 313.51 ms | 355.43 ms | 41.92 ms |
| dba088c | 365.46 ms | 366.31 ms | 0.85 ms |
| fc5ccaf | 270.49 ms | 363.90 ms | 93.41 ms |
| fcec2f2 | 328.91 ms | 387.75 ms | 58.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5b66efd | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| 6405ec5 | 1.58 MiB | 2.12 MiB | 552.23 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 539ca63 | 1.58 MiB | 2.12 MiB | 551.41 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
Previous results on branch: feature/profiling-in-samples-and-system-test
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 18e412b | 352.65 ms | 455.36 ms | 102.71 ms |
| 90ef31c | 291.34 ms | 363.52 ms | 72.18 ms |
| 1624838 | 336.10 ms | 449.19 ms | 113.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 18e412b | 1.58 MiB | 2.13 MiB | 559.20 KiB |
| 90ef31c | 1.58 MiB | 2.13 MiB | 559.19 KiB |
| 1624838 | 1.58 MiB | 2.13 MiB | 559.20 KiB |
| assertEquals(person.lastName, returnedPerson!!.lastName) | ||
|
|
||
| testHelper.ensureTransactionReceived { transaction, envelopeHeader -> | ||
| profilerId = transaction.contexts.profile?.profilerId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a leftover from creating the test? should we remove it here since it's not asserting and the other test is actually asserting
….com:getsentry/sentry-java into feature/profiling-in-samples-and-system-test
….com:getsentry/sentry-java into feature/profiling-in-samples-and-system-test
| mapOf( | ||
| "SENTRY_DSN" to testHelper.dsn, | ||
| // "SENTRY_AUTO_INIT" to "false", | ||
| // "SENTRY_AUTO_INIT" to "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Commented-out debug code leftover from testing
The commented-out SENTRY_AUTO_INIT environment variable appears to be a leftover from development. The diff shows it was changed from "false" to "true" while remaining commented out, indicating this was part of local testing and wasn't meant to be committed. As the PR reviewer noted, this line doesn't contribute anything to the test and could be removed.
📜 Description
💡 Motivation and Context
resolves: #4941
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps