Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

options
.getClientReportRecorder()
.recordLostEvent(DiscardReason.QUEUE_OVERFLOW, DataCategory.Attachment, lostBytes);
.recordLostEvent(DiscardReason.QUEUE_OVERFLOW, DataCategory.LogByte, lostBytes);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a test for this

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Report discarded log in batch processor as `log_byte` ([#4971](https://github.com/getsentry/sentry-java/pull/4971))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 904f41a

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 311.86 ms 358.65 ms 46.79 ms
Size 1.58 MiB 2.13 MiB 559.52 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d205d0 352.15 ms 432.53 ms 80.38 ms
fc5ccaf 256.80 ms 322.36 ms 65.56 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms
6edfca2 314.02 ms 383.20 ms 69.18 ms
674d437 355.28 ms 504.18 ms 148.90 ms
6405ec5 310.88 ms 354.56 ms 43.69 ms
bbc35bb 324.88 ms 425.73 ms 100.85 ms
dba088c 321.78 ms 364.59 ms 42.82 ms
fc5ccaf 279.11 ms 353.34 ms 74.23 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms

App size

Revision Plain With Sentry Diff
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
6edfca2 1.58 MiB 2.13 MiB 559.07 KiB
674d437 1.58 MiB 2.10 MiB 530.94 KiB
6405ec5 1.58 MiB 2.12 MiB 552.23 KiB
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants