Skip to content

feat(metrics): [Trace Metrics 9] Metrics Distribution API #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 1 commit into
base: 12-18-metrics_count_api
Choose a base branch
from
+54 −1
Draft

feat(metrics): [Trace Metrics 9] Metrics Distribution API #4988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sentry/api/sentry.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5206,6 +5206,9 @@ public abstract interface class io/sentry/metrics/IMetricsApi {
public abstract fun count (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public abstract fun count (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public abstract fun count (Ljava/lang/String;Ljava/lang/String;)V
public abstract fun distribution (Ljava/lang/String;Ljava/lang/Double;)V
public abstract fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public abstract fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
}

public abstract interface class io/sentry/metrics/IMetricsBatchProcessor {
Expand All @@ -5225,6 +5228,9 @@ public final class io/sentry/metrics/MetricsApi : io/sentry/metrics/IMetricsApi
public fun count (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun count (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public fun count (Ljava/lang/String;Ljava/lang/String;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
}

public class io/sentry/metrics/MetricsBatchProcessor : io/sentry/metrics/IMetricsBatchProcessor {
Expand All @@ -5244,6 +5250,9 @@ public final class io/sentry/metrics/NoOpMetricsApi : io/sentry/metrics/IMetrics
public fun count (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun count (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public fun count (Ljava/lang/String;Ljava/lang/String;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public static fun getInstance ()Lio/sentry/metrics/NoOpMetricsApi;
}

Expand Down
12 changes: 11 additions & 1 deletion sentry/src/main/java/io/sentry/metrics/IMetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,17 @@ void count(
final @Nullable String unit,
final @NotNull SentryLogParameters params);

// distribution
void distribution(final @NotNull String name, final @Nullable Double value);

void distribution(
final @NotNull String name, final @Nullable Double value, final @Nullable String unit);

void distribution(
final @NotNull String name,
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params);

// gauge
//
}
20 changes: 20 additions & 0 deletions sentry/src/main/java/io/sentry/metrics/MetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,26 @@ public void count(
captureMetrics(params, name, "counter", value, unit);
}

@Override
public void distribution(final @NotNull String name, final @Nullable Double value) {
captureMetrics(SentryLogParameters.create(null, null), name, "distribution", value, null);
}

@Override
public void distribution(
final @NotNull String name, final @Nullable Double value, final @Nullable String unit) {
captureMetrics(SentryLogParameters.create(null, null), name, "distribution", value, unit);
}

@Override
public void distribution(
final @NotNull String name,
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params) {
captureMetrics(params, name, "distribution", value, unit);
}

@SuppressWarnings("AnnotateFormatMethod")
private void captureMetrics(
final @NotNull SentryLogParameters params,
Expand Down
14 changes: 14 additions & 0 deletions sentry/src/main/java/io/sentry/metrics/NoOpMetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,18 @@ public void count(
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params) {}

@Override
public void distribution(final @NotNull String name, final @Nullable Double value) {}

@Override
public void distribution(
final @NotNull String name, final @Nullable Double value, final @Nullable String unit) {}

@Override
public void distribution(
final @NotNull String name,
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params) {}
}
Loading