Skip to content

feat(metrics): [Trace Metrics 10] Metrics Gauge API #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 1 commit into
base: 12-18-metrics_distribution_api
Choose a base branch
from
+52 −2
Draft

feat(metrics): [Trace Metrics 10] Metrics Gauge API #4989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sentry/api/sentry.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5209,6 +5209,9 @@ public abstract interface class io/sentry/metrics/IMetricsApi {
public abstract fun distribution (Ljava/lang/String;Ljava/lang/Double;)V
public abstract fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public abstract fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public abstract fun gauge (Ljava/lang/String;Ljava/lang/Double;)V
public abstract fun gauge (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public abstract fun gauge (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
}

public abstract interface class io/sentry/metrics/IMetricsBatchProcessor {
Expand All @@ -5231,6 +5234,9 @@ public final class io/sentry/metrics/MetricsApi : io/sentry/metrics/IMetricsApi
public fun distribution (Ljava/lang/String;Ljava/lang/Double;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public fun gauge (Ljava/lang/String;Ljava/lang/Double;)V
public fun gauge (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun gauge (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
}

public class io/sentry/metrics/MetricsBatchProcessor : io/sentry/metrics/IMetricsBatchProcessor {
Expand All @@ -5253,6 +5259,9 @@ public final class io/sentry/metrics/NoOpMetricsApi : io/sentry/metrics/IMetrics
public fun distribution (Ljava/lang/String;Ljava/lang/Double;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun distribution (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public fun gauge (Ljava/lang/String;Ljava/lang/Double;)V
public fun gauge (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;)V
public fun gauge (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/String;Lio/sentry/logger/SentryLogParameters;)V
public static fun getInstance ()Lio/sentry/metrics/NoOpMetricsApi;
}

Expand Down
11 changes: 9 additions & 2 deletions sentry/src/main/java/io/sentry/metrics/IMetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ void distribution(
final @Nullable String unit,
final @NotNull SentryLogParameters params);

// gauge
//
void gauge(final @NotNull String name, final @Nullable Double value);

void gauge(final @NotNull String name, final @Nullable Double value, final @Nullable String unit);

void gauge(
final @NotNull String name,
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params);
}
20 changes: 20 additions & 0 deletions sentry/src/main/java/io/sentry/metrics/MetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,26 @@ public void distribution(
captureMetrics(params, name, "distribution", value, unit);
}

@Override
public void gauge(final @NotNull String name, final @Nullable Double value) {
captureMetrics(SentryLogParameters.create(null, null), name, "gauge", value, null);
}

@Override
public void gauge(
final @NotNull String name, final @Nullable Double value, final @Nullable String unit) {
captureMetrics(SentryLogParameters.create(null, null), name, "gauge", value, unit);
}

@Override
public void gauge(
final @NotNull String name,
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params) {
captureMetrics(params, name, "gauge", value, unit);
}

@SuppressWarnings("AnnotateFormatMethod")
private void captureMetrics(
final @NotNull SentryLogParameters params,
Expand Down
14 changes: 14 additions & 0 deletions sentry/src/main/java/io/sentry/metrics/NoOpMetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,18 @@ public void distribution(
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params) {}

@Override
public void gauge(final @NotNull String name, final @Nullable Double value) {}

@Override
public void gauge(
final @NotNull String name, final @Nullable Double value, final @Nullable String unit) {}

@Override
public void gauge(
final @NotNull String name,
final @Nullable Double value,
final @Nullable String unit,
final @NotNull SentryLogParameters params) {}
}
Loading