Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member Author

adinauer commented Dec 22, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- [Trace Metrics 16] Only send user attributes if sendDefaultPii is true ([#4995](https://github.com/getsentry/sentry-java/pull/4995))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 6cdbfb7

@adinauer adinauer changed the title Only send user attributes if sendDefaultPii is true feat(metrics): [Trace Metrics 16] Only send user attributes if sendDefaultPii is true Dec 22, 2025
@adinauer adinauer marked this pull request as ready for review December 22, 2025 12:59
Comment on lines +234 to +236
if (scopes.getOptions().isSendDefaultPii()) {
setUser(attributes);
}

This comment was marked as outdated.

@adinauer adinauer force-pushed the 12-22-only_send_user_attributes_if_senddefaultpii_is_true branch from 106a66c to 6cdbfb7 Compare December 22, 2025 13:41
@adinauer adinauer force-pushed the 12-19-android_metrics_batch_processor_and_factory branch from c3c0f3b to 0116a6b Compare December 22, 2025 13:41
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 301.24 ms 360.51 ms 59.27 ms
Size 1.58 MiB 2.13 MiB 560.97 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants