Add listEC2Runners verification to maximum runners test #4980
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
'calls publishRetryMessage even when maximum runners is reached'was missing verification thatlistEC2Runnersis called when checking runner limits.Changes
listEC2Runnersis called with correct parameters whenRUNNERS_MAXIMUM_COUNT='0'toHaveBeenCalledWithmatcher for consistency with modern Vitest practicesAccording to the scale-up logic (scale-up.ts:370-371), when
maximumRunnersis not -1,listEC2Runnersmust be called to get the current runner count. The test now verifies this behavior occurs as expected:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.