-
Notifications
You must be signed in to change notification settings - Fork 72
Fix permissions for update-release* workflows #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes GitHub Actions workflow configurations for release management by moving permissions from workflow-level to job-level, updating action versions from v5 to v6, and improving workflow structure. This change enhances security by applying the principle of least privilege at the job level.
- Relocated permissions from workflow-level to job-level for better security granularity
- Updated
actions/checkoutandactions/setup-pythonfrom v5 to v6 - Added formatting improvements (blank lines) for better readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/update-release.yml |
Moved permissions from workflow-level (lines 2-5) to job-level (lines 26-29), updated actions/checkout and actions/setup-python to v6 |
.github/workflows/update-release-status.yml |
Moved permissions from workflow-level to job-level for both the validate-check-runs job (lines 21-24) and the update-release job (lines 135-138), updated actions/checkout to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
knewbury01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This pull request updates the GitHub Actions workflows related to release management. The main focus is on improving permissions handling by moving permissions from the workflow level to the job level, updating action versions, and ensuring permissions are properly set for each job. These changes enhance workflow security and maintain compatibility with the latest action versions.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.