Skip to content

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Dec 15, 2025

Relevant DCA experiment is the "Open" one. Note that there are a number of new extraction errors on SideStore due to module version mismatches, giving a reduction in the number of alerts. Since we already have a number of similar errors on other DCA projects I propose we accept these.

a04b10c is somewhat of a hack to work around some data set check errors visible the integration tests. I wonder if there is some more principled way to deal with unavailable declarations. I did not investigate this further are part of this point update.

@github-actions github-actions bot added the Swift label Dec 15, 2025
@jketema jketema force-pushed the swift-6.2.3 branch 2 times, most recently from fadf31e to a04b10c Compare December 18, 2025 13:28
@jketema jketema marked this pull request as ready for review December 18, 2025 14:57
@jketema jketema requested a review from a team as a code owner December 18, 2025 14:57
Copilot AI review requested due to automatic review settings December 18, 2025 14:57
@jketema jketema requested a review from a team as a code owner December 18, 2025 14:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Swift extractor to support Swift 6.2.3. The update includes refreshed prebuilt Swift binaries and resource directories for both macOS and Linux platforms, along with code changes to handle unavailable declarations properly.

  • Updated prebuilt Swift toolchain binaries and resource directories for macOS and Linux to Swift 6.2.3
  • Added handling to skip unavailable declarations in lookup expressions
  • Added type mapping for BuiltinImplicitActorType (SIL type)

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
swift/third_party/resources/swift-prebuilt-macos.tar.zst Updated macOS prebuilt Swift 6.2.3 toolchain binary with new SHA256 hash and size
swift/third_party/resources/swift-prebuilt-linux.tar.zst Updated Linux prebuilt Swift 6.2.3 toolchain binary with new SHA256 hash and size
swift/third_party/resources/resource-dir-macos.zip Updated macOS resource directory for Swift 6.2.3 with new SHA256 hash and size
swift/third_party/resources/resource-dir-linux.zip Updated Linux resource directory for Swift 6.2.3 with new SHA256 hash and size
swift/ql/lib/change-notes/2025-12-18-swift-6.2.3.md Added change notes documenting the Swift 6.2.3 upgrade as a major analysis change
swift/extractor/translators/ExprTranslator.cpp Added check to skip unavailable declarations when processing lookup expressions
swift/extractor/infra/SwiftTagTraits.h Added type mapping for BuiltinImplicitActorType as a SIL-only type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your assessment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants