fix: typo in "failure_reaction" #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo where the reaction input key was incorrectly named "failed_reaction" instead of "failure_reaction", ensuring consistency with the repository's README.
- Fixed the reaction input key for the failure condition in the post function.
- Updated tests to verify the correct reaction is used on both success and failure outcomes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/functions/post.js | Renamed input from "failed_reaction" to "failure_reaction" |
| tests/functions/post.test.js | Added tests to check the updated behavior for reaction inputs |
Contributor
Author
|
@GrantBirki Could you please review this? |
GrantBirki
approved these changes
May 9, 2025
Contributor
GrantBirki
left a comment
GrantBirki
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Contributor
|
A new release, |
Contributor
Author
|
@GrantBirki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #77
The repository's README says "failure_reaction", but the source code uses "failed_reaction". This PR fixes this to use "failure_reaction" and adds tests.