Do not try to base64 decode empty values #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for consul kv items to be empty, e.g. you might get
something like
{"CreateIndex":915,"ModifyIndex":915,"LockIndex":0,"Key":"some/key/prefix","Flags":4,"Value":null}
In this case, node-consul will attempt to base64 decode this, which
results in an exception being thrown, e.g.:
TypeError: Cannot read property 'length' of null
at new Buffer (buffer.js:184:31)
at
/proj/node_modules/consul-node/lib/kv.js:49:16
...
This prevents that from happening.
Author
|
Also added an for /v1/catalog/services. See commit log. |
Provide an api that allows us to query the /v1/catalog/services endpoint.
a string or other type, it errors out. We need to make sure that JS objects are correctly serialized as JSON in the request body. To do this, we set req.json instead of req.body upstream to the underlying request library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for consul kv items to be empty, e.g. you might get
something like
{"CreateIndex":915,"ModifyIndex":915,"LockIndex":0,"Key":"some/key/prefix","Flags":4,"Value":null}
In this case, node-consul will attempt to base64 decode this, which
results in an exception being thrown, e.g.:
TypeError: Cannot read property 'length' of null
at new Buffer (buffer.js:184:31)
at
/proj/node_modules/consul-node/lib/kv.js:49:16
...
This prevents that from happening.