Skip to content

Conversation

@mzbush
Copy link
Contributor

@mzbush mzbush commented Dec 18, 2025

Description

Fix bug in mpcd pytest with rigid bodies in which the mpcd particles are not placed in the same cell as the constituent particles.

Motivation and context

The mpcd pytests that check momentum conservation when colliding with rigid body constituent particles require that mpcd particles be placed in the same location as the constituent particles to ensure a collision occurs. When testing periodic boundaries by placing the rigid body in a corner of the simulation box, the mpcd particles were not placed in the right location.

How has this been tested?

The positions in the test have been checked manually to ensure they are now in the right place.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the HOOMD-blue Contributor Agreement.
  • My name is on the list of contributors (sphinx-doc/credits.rst) in the pull request source branch.
  • I have summarized these changes in CHANGELOG.rst following the established format.

Copy link
Collaborator

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a needed and straightforward fix. Please implement the minor changes below to make the test clearer in future.

mzbush and others added 2 commits December 18, 2025 16:40
Co-authored-by: Michael Howard <mphoward@auburn.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants