-
-
Notifications
You must be signed in to change notification settings - Fork 80
feat: Add Google Maps and File Search tool support #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit introduces comprehensive support for Google Maps and File Search tools, enhancing the client's grounding capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive support for Google Maps and File Search tools to enhance the Gemini client's grounding capabilities. The implementation introduces new data classes for these tools and their configurations, integrates them into the existing Tool system, and provides comprehensive test coverage and documentation.
Key Changes:
- Added
GoogleMaps,FileSearch, andRetrievalConfigdata classes with proper serialization support - Extended
ToolandToolConfigto support the new grounding tools - Added comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/Data/GoogleMaps.php |
Implements GoogleMaps tool with optional enableWidget parameter, follows stdClass pattern for empty state |
src/Data/FileSearch.php |
Implements FileSearch tool with required fileSearchStoreNames and optional metadataFilter |
src/Data/RetrievalConfig.php |
Implements geographical context configuration with latitude/longitude for use with GoogleMaps |
src/Data/Tool.php |
Extends Tool class to support googleMaps and fileSearch parameters |
src/Data/ToolConfig.php |
Extends ToolConfig to support retrievalConfig for geographical grounding |
tests/Data/Tool.php |
Comprehensive tests for GoogleMaps and FileSearch tool serialization |
tests/Data/ToolConfig.php |
Tests for ToolConfig with RetrievalConfig in various combinations |
src/Testing/Resources/FileSearchStoresTestResource.php |
Test resource referencing missing contract, resource, and response classes (incomplete implementation) |
src/Testing/ClientFake.php |
Adds fileSearchStores() method without corresponding implementation in real Client |
README.md |
Documentation for Google Maps and File Search grounding with examples and usage patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
PR #157 should be accepted first |
|
Hi @jfradj |
This commit introduces comprehensive support for Google Maps and File Search tools, enhancing the client's grounding capabilities.