Skip to content

Conversation

@jfradj
Copy link
Contributor

@jfradj jfradj commented Dec 1, 2025

This commit introduces comprehensive support for Google Maps and File Search tools, enhancing the client's grounding capabilities.

This commit introduces comprehensive support for Google Maps and File Search tools, enhancing the client's grounding capabilities.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive support for Google Maps and File Search tools to enhance the Gemini client's grounding capabilities. The implementation introduces new data classes for these tools and their configurations, integrates them into the existing Tool system, and provides comprehensive test coverage and documentation.

Key Changes:

  • Added GoogleMaps, FileSearch, and RetrievalConfig data classes with proper serialization support
  • Extended Tool and ToolConfig to support the new grounding tools
  • Added comprehensive test coverage for the new functionality

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Data/GoogleMaps.php Implements GoogleMaps tool with optional enableWidget parameter, follows stdClass pattern for empty state
src/Data/FileSearch.php Implements FileSearch tool with required fileSearchStoreNames and optional metadataFilter
src/Data/RetrievalConfig.php Implements geographical context configuration with latitude/longitude for use with GoogleMaps
src/Data/Tool.php Extends Tool class to support googleMaps and fileSearch parameters
src/Data/ToolConfig.php Extends ToolConfig to support retrievalConfig for geographical grounding
tests/Data/Tool.php Comprehensive tests for GoogleMaps and FileSearch tool serialization
tests/Data/ToolConfig.php Tests for ToolConfig with RetrievalConfig in various combinations
src/Testing/Resources/FileSearchStoresTestResource.php Test resource referencing missing contract, resource, and response classes (incomplete implementation)
src/Testing/ClientFake.php Adds fileSearchStores() method without corresponding implementation in real Client
README.md Documentation for Google Maps and File Search grounding with examples and usage patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jfradj and others added 15 commits December 15, 2025 11:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jfradj
Copy link
Contributor Author

jfradj commented Dec 15, 2025

PR #157 should be accepted first

@aydinfatih
Copy link
Member

Hi @jfradj
Thanks for your contribution. There are errors in the github actions. Can you fix them? The commands you need are defined in the composer.json file.

@jfradj jfradj closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants