Skip to content

Conversation

@AkshatG6
Copy link
Contributor

@AkshatG6 AkshatG6 commented Jan 6, 2026

This PR acts as a main feature branch that adds support for requesting claims via the SignInWith... public method. Currently, only auth_time claim is supported.

This pull request introduces the `GIDTokenClaimsInternalOptions` class, a new component designed to handle the validation and JSON serialization of token claims.

Key changes:

* Adds the `GIDTokenClaimsInternalOptions` class to validate the token claims and return a JSON object.
* Adds the `GIDJSONSerializer` protocol with real and fake implementations to support serializing the token claims.
* Provides unit tests to validate the implementation.
@AkshatG6 AkshatG6 requested review from brnnmrls and mdmathias January 6, 2026 22:49
Copy link
Member

@brnnmrls brnnmrls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the unit tests are passing before merging.

@AkshatG6 AkshatG6 merged commit 7aee035 into main Jan 7, 2026
16 checks passed
@AkshatG6 AkshatG6 deleted the gandhiakshat/sbc-auth_time branch January 7, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants