Fix flaky tests in TestParameterInjectorKotlinTest by enforcing field processing order #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified
TestParameterMethodProcessor.getFieldValueHoldersto sort the fields returned byClass.getDeclaredFields()alphabetically. This ensures that the order in which@TestParameterannotated fields are processed is deterministic.Motivation
NonDex detected test flakiness in:
com.google.testing.junit.testparameterinjector.TestParameterInjectorKotlinTest#test_success[TestParameter_PrimaryConstructorParamMixedWithField]com.google.testing.junit.testparameterinjector.TestParameterMethodProcessorTest#test_success[MultipleAnnotatedFieldsAndParameters]This is due to the non-deterministic order of fields returned by
Class.getDeclaredFields(). TheTestParameterInjectoruses this order to generate test names (for example test[param1=val1, param2=val2]). When the order of fields changes the generated test names change, causing assertions that expect a specific order to fail. Sorting the fields ensures a consistent order regardless of JVM implementation or runtime conditions. NonDex output with the failure attached.nondex_output__.txt