-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(tools): Use function declaration for VertexAiRagRetrieval in Gemini 2.x+ #3912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ni 2.x+ Standardize VertexAiRagRetrieval to always use function declarations, even for Gemini 2.x+ models. This prevents unnecessary direct retrieval configurations and resolves premature API calls and 429 errors when the tool is not explicitly invoked. This ensures the RAG tool is only called when the model explicitly invokes its declared function. Fixes google#3315
Summary of ChangesHello @danicat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the integration of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request standardizes VertexAiRagRetrieval to always use function declarations, removing the special handling for Gemini 2.x+ models. This change simplifies the implementation in vertex_ai_rag_retrieval.py by removing conditional logic, which improves maintainability and resolves the issues with premature API calls described in the pull request. The corresponding unit test in test_vertex_ai_rag_retrieval.py has been correctly updated to assert the new, unified behavior. The changes are clear, well-justified, and appear to be a solid fix.
|
Hi @danicat , Thank you for your contribution! We appreciate you taking the time to submit this pull request. |
|
Hi @seanzhou1023 , can you please review this. |
Standardize VertexAiRagRetrieval to always use function declarations, even for Gemini 2.x+ models. This prevents unnecessary direct retrieval configurations and resolves premature API calls and 429 errors when the tool is not explicitly invoked. This ensures the RAG tool is only called when the model explicitly invokes its declared function.
Link to Issue
Testing Plan
Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.All tests pass but pytest is very noisy with thousands of warnings:
I didn't try to tackle any of the warnings as they aren't related to the change.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
adk create rag_testadk webChecklist
Additional context
Add any other context or screenshots about the feature request here.