Skip to content

bugfix: Write JSON formatted string #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ftnext wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −3
Open

bugfix: Write JSON formatted string #3994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb7e82a
bugfix: Write JSON formatted string
ftnext Dec 21, 2025
3e83554
test: Use model_dump(mode="json")
ftnext Dec 21, 2025
7575627
bugfix: Use model_dump(mode="json")
ftnext Dec 21, 2025
f2b9bdd
Fix get_eval_set_result
ftnext Dec 21, 2025
acb35ba
Merge branch 'main' into fix-double-encoded-json
ftnext Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/google/adk/evaluation/local_eval_set_results_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def save_eval_set_result(
if not os.path.exists(app_eval_history_dir):
os.makedirs(app_eval_history_dir)
# Convert to json and write to file.
eval_set_result_json = eval_set_result.model_dump_json()
eval_set_result_json = eval_set_result.model_dump(mode="json")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly fixes the serialization bug, the variable eval_set_result_json now holds a Python dictionary rather than a JSON string, making the name misleading. For improved code clarity, I recommend renaming it to something like eval_set_result_data or eval_set_result_dict. Note that this would also require updating the variable name on line 64.

eval_set_result_file_path = os.path.join(
app_eval_history_dir,
eval_set_result.eval_set_result_name + _EVAL_SET_RESULT_FILE_EXTENSION,
Expand All @@ -80,7 +80,7 @@ def get_eval_set_result(
raise NotFoundError(f"Eval set result `{eval_set_result_id}` not found.")
with open(maybe_eval_result_file_path, "r", encoding="utf-8") as file:
eval_result_data = json.load(file)
return EvalSetResult.model_validate_json(eval_result_data)
return EvalSetResult.model_validate(eval_result_data)

@override
def list_eval_set_results(self, app_name: str) -> list[str]:
Expand Down
2 changes: 1 addition & 1 deletion tests/unittests/evaluation/test_local_eval_set_results_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_save_eval_set_result(self, mocker):
actual_eval_set_result_json = json.load(f)

# need to convert eval_set_result to json
expected_eval_set_result_json = self.eval_set_result.model_dump_json()
expected_eval_set_result_json = self.eval_set_result.model_dump(mode="json")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly aligns the test with the fix in the application code. However, similar to the main code, the variable expected_eval_set_result_json now contains a dictionary. To improve readability and consistency, consider renaming it to expected_eval_set_result_data. This naming suggestion also applies to actual_eval_set_result_json on line 88.

assert expected_eval_set_result_json == actual_eval_set_result_json

def test_get_eval_set_result(self, mocker):
Expand Down
Loading