impl(spanner): remove deprecated ClientOptions

[mpeddada1]

Removed deprecated client_options files from spanner module. Also removes Client constructor that takes in ClientOptions.

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant cleanup effort within the Spanner C++ client library by entirely removing the deprecated ClientOptions class. This change streamlines the API by ensuring that all client configurations now exclusively utilize the modern Options mechanism, thereby simplifying maintenance and promoting a consistent approach to option handling across the library.

Highlights

• Removal of Deprecated ClientOptions: The ClientOptions class, previously marked as deprecated, has been completely removed from the Spanner client library.
• Codebase Cleanup: All references, includes, and usage of the ClientOptions class have been purged from the client.h header and its associated test files.
• Build System Updates: The build configurations in CMakeLists.txt and Bazel files (google_cloud_cpp_spanner.bzl, spanner_client_unit_tests.bzl) have been updated to remove references to the deleted client_options.h and client_options_test.cc.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the deprecated ClientOptions class and its usage throughout the Spanner client library. The changes are mostly cleanups and file removals.

I've left a couple of suggestions:

1. There seems to be a leftover constructor in client.h that was part of the ClientOptions backward compatibility and can now be removed.
2. A test case in client_test.cc is being removed, but it seems to test an important aspect of google::cloud::Options precedence. I've suggested restoring it with a more accurate name.

Overall, this is a good cleanup PR.

I am having trouble creating individual review comments. Click here to see my feedback.

google/cloud/spanner/client.h (719-721)

This constructor seems to be a leftover from the removal of the Client(..., ClientOptions const&) constructor. Now that the ClientOptions constructor is gone, there is no ambiguity for Client(conn, {}), so this constructor is no longer needed and can be removed.

google/cloud/spanner/client_test.cc (1316-1334)

This test seems valuable as it verifies that options passed to the Client constructor override options from the Connection. The test name is a bit misleading as it's not testing the deprecated ClientOptions class but google::cloud::Options. I suggest we keep this test and rename it to something more descriptive, like UsesClientConstructorOptions.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (d0db317) to head (363be8f).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15849      +/-   ##
======================================================
- Coverage               92.95%   92.94%   -0.01%     
======================================================
  Files                    2454     2452       -2     
  Lines                  227401   227339      -62     
======================================================
- Hits                   211380   211304      -76     
- Misses                  16021    16035      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.