impl(spanner): remove MakeTestRow which was been deprecated

[mpeddada1]

Moves implementation of MakeTestRow to mocks/row.h under MakeRow and removes MakeTestRow methods.

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Spanner client library by removing the deprecated MakeTestRow functions and integrating their underlying implementation directly into the MakeRow functions located in the spanner_mocks namespace. This streamlines the API by eliminating obsolete functions and centralizes test-specific row creation logic, enhancing maintainability and clarity for mocking scenarios.

Highlights

• Deprecated Function Removal: The MakeTestRow functions, previously marked as deprecated, have been completely removed from google/cloud/spanner/row.h and google/cloud/spanner/row.cc.
• Implementation Relocation: The underlying logic for creating test rows has been moved from the deprecated MakeTestRow functions and integrated directly into the MakeRow functions within google/cloud/spanner/mocks/row.h.
• Consolidation of Mocking Utilities: This change consolidates the row creation utilities specifically for mocking purposes into the spanner_mocks namespace, improving code organization and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the deprecated MakeTestRow function and moves its implementation to spanner_mocks::MakeRow. The changes are clean and achieve the intended refactoring. I've added a couple of suggestions to improve performance by pre-allocating memory for vectors where the size is known, which can prevent reallocations.

[gemini-code-assist]

To improve performance by avoiding potential reallocations, it's good practice to reserve space for the vectors since their final size is known in advance.

  auto values = std::vector<spanner::Value>{};
  values.reserve(pairs.size());
  auto columns = std::make_shared<std::vector<std::string>>();
  columns->reserve(pairs.size());

[gemini-code-assist]

To improve performance by avoiding potential reallocations, it's good practice to reserve space for the columns vector since its final size is known in advance.

  auto columns = std::make_shared<std::vector<std::string>>();
  columns->reserve(sizeof...(ts));
  for (std::size_t i = 0; i < sizeof...(ts); ++i) {
    columns->emplace_back(std::to_string(i));
  }

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (d0db317) to head (e4eae92).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15850      +/-   ##
======================================================
- Coverage               92.95%   92.94%   -0.01%     
======================================================
  Files                    2454     2454              
  Lines                  227401   227397       -4     
======================================================
- Hits                   211380   211362      -18     
- Misses                  16021    16035      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.