Skip to content

Conversation

@PierrickVoulet
Copy link
Contributor

Moved to google-chat-app

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PierrickVoulet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the repository by completely removing the attendance-chat-app solution. This change is implemented because the application's functionality has been relocated to the google-chat-app, ensuring that the repository maintains only the most current and relevant solutions and avoids redundancy.

Highlights

  • Removal of Attendance Chat App: The entire attendance-chat-app solution, including its documentation and code files across various development steps, has been completely removed from the repository.
  • Relocation of Functionality: This removal is due to the application's functionality being moved to a new location, specifically the google-chat-app, as indicated in the pull request description.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@PierrickVoulet PierrickVoulet merged commit a82c548 into googleworkspace:main Dec 11, 2025
9 of 31 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'attendance-chat-app' sample application, as it has been moved to a different location. The changes involve deleting the entire solutions/attendance-chat-app directory. While reviewing the deleted code, I noticed a potential issue in solutions/attendance-chat-app/final/Code.gs regarding the mutation of a global constant, which could lead to race conditions. Since the code is being moved, I've left a comment on the deleted file for your consideration in the new location. Otherwise, the file removal is complete and correct.

I am having trouble creating individual review comments. Click here to see my feedback.

solutions/attendance-chat-app/final/Code.gs (72-81)

high

The global HEADER constant is mutated here. This is not a good practice as it introduces side effects and can lead to race conditions if the script handles multiple messages concurrently. For example, if two users interact with the app at the same time, one might see an incorrect header image. Since this code is being moved, it's a good opportunity to refactor this. A better approach would be to create a new header object within this function with the appropriate imageUrl and pass it to the createCardResponse function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant