Skip to content

Commit 2458b6c

Browse files
committed
Fix - UserOptions - Fix name collision & simplify toggle event management (#221)
1 parent 9ac72f7 commit 2458b6c

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

src/atoms/UserOptions.vue

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -255,20 +255,26 @@ function toggleTooltip() {
255255
}
256256
}
257257
258-
const _isFullscreen = ref(props.isFullscreen);
258+
const _isFullscreen = computed({
259+
get: () => props.isFullscreen,
260+
set: (val) => emit('toggleFullscreen', val)
261+
});
259262
260-
async function toggleFullscreen() {
263+
function toggleFullscreen() {
261264
if (!props.chartElement) return;
262-
if (_isFullscreen.value) {
263-
document.exitFullscreen();
265+
266+
const next = !props.isFullscreen;
267+
_isFullscreen.value = next;
268+
269+
if (next) {
270+
props.chartElement.requestFullscreen()
264271
} else {
265-
await props.chartElement.requestFullscreen();
272+
document.exitFullscreen();
266273
}
267274
}
268275
269276
function fullscreenchanged() {
270277
const flag = !!document.fullscreenElement;
271-
_isFullscreen.value = flag;
272278
emit('toggleFullscreen', flag);
273279
}
274280

0 commit comments

Comments
 (0)