refactor: migrate AWS resources to generic Resource[C] pattern #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james00012
force-pushed
the
feat/generic-resource-combined
branch
from
c2a5a8e to
86903df
Compare
This refactoring introduces a type-safe generic resource pattern that simplifies AWS resource implementations and reduces code duplication. Key changes: - Introduce Resource[C] generic type with type-safe client handling - Add WrapAwsInitClient helper for AWS config initialization - Add batch deleters: SimpleBatchDeleter, SequentialDeleter, BulkDeleter, MultiStepDeleter, DeleteThenWait - Merge all *_types.go files into main resource files (55 files deleted) - Remove base_resource.go, common.go, globals.go (consolidated into adapter.go) - Update golangci-lint config for v2 compatibility - Fix context key type for SA1029 compliance - Add pagination support across all resources Net reduction: ~5,500 lines of code across 280 files changed.
james00012
force-pushed
the
feat/generic-resource-combined
branch
from
86903df to
8d5a91f
Compare
denis256
reviewed
Jan 2, 2026
denis256
reviewed
Jan 2, 2026
denis256
reviewed
Jan 2, 2026
…C2 resources - Add DefaultBatchSize=50 constant, standardize batch sizes across resources - Add NewEC2AwsResource helper for EC2 resources with DefaultOnly support - Expand awsDefaults command to delete VPC dependencies (endpoints, NAT gateways, ENIs, IGWs, subnets) before VPCs - Update EC2Endpoint, NatGateway, InternetGateway, NetworkInterface config types to EC2ResourceType - Remove unused nukeInternetGateway and nukeVpcEndpoint functions - Fix tests to use DefaultBatchSize constant
james00012
force-pushed
the
feat/generic-resource-combined
branch
from
d979ea8 to
37f43a5
Compare
denis256
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a type-safe generic
Resource[C]pattern that consolidates duplicate boilerplate across all AWS resource implementations.Key Changes
SimpleBatchDeleter,SequentialDeleter,BulkDeleter,DeleteThenWait, etc.)NewEC2AwsResourcehelper for EC2 resources that support default VPC filtering*_types.gofiles consolidated into main resource filesImpact
*_types.gofiles deletedDeleter Functions
SimpleBatchDeleterSequentialDeleterBulkDeleterMultiStepDeleterDeleteThenWaitTesting