Skip to content

Conversation

@TheWizardofGauze
Copy link
Contributor

Bringing it up to date with latest JSON additions.

Copy link
Member

@dealloc dealloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheWizardofGauze just making sure because it looks weird on GitHub mobile, this is just a submodule update?

@TheWizardofGauze
Copy link
Contributor Author

@TheWizardofGauze just making sure because it looks weird on GitHub mobile, this is just a submodule update?

It should be. I had some issues updating it last night, it didn't want to cooperate and I ended up resetting my fork and cloning it fresh.

I did notice that it seemed different from before, that it updated the submodule, but also showed changes for files in the submodule?

@dealloc
Copy link
Member

dealloc commented Sep 6, 2025

@TheWizardofGauze just making sure because it looks weird on GitHub mobile, this is just a submodule update?

It should be. I had some issues updating it last night, it didn't want to cooperate and I ended up resetting my fork and cloning it fresh.

I did notice that it seemed different from before, that it updated the submodule, but also showed changes for files in the submodule?

that's what I was worried about too, usually it only shows an updated submodule. I'll investigate a little closer before giving this the go-ahead

@dealloc
Copy link
Member

dealloc commented Sep 6, 2025

I'm fairly certain something went wrong with the update, as the changed JSON files are actually checked into the repository (see below)
image
which they aren't in the original
image

I'd say reset the branch, follow the instructions for updating the JSON submodule on helldivers-2/json (make sure to navigate to the correct folder) and try again.

@TheWizardofGauze
Copy link
Contributor Author

I'm fairly certain something went wrong with the update, as the changed JSON files are actually checked into the repository (see below) image which they aren't in the original image

I'd say reset the branch, follow the instructions for updating the JSON submodule on helldivers-2/json (make sure to navigate to the correct folder) and try again.

Oh! I see it now, I'll take another look and try and find what went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants