feat(ci): add ci/cd pipeline #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangsonww
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GitHub Actions workflow to automate code formatting and linting on pushes and pull requests to the master branch.
- Defines a CI/CD pipeline that runs formatting and lint jobs.
- Adds a final status step to always report pipeline completion.
Comments suppressed due to low confidence (3)
.github/workflows/ci.yml:16
- Using
continue-on-error: trueon critical steps will mask failures; consider removing this flag so the CI job fails when formatting or lint errors occur.
continue-on-error: true
.github/workflows/ci.yml:29
- [nitpick] In CI, prefer using a format check command (e.g.,
npm run format -- --check) instead of mutating code to enforce formatting consistency without modifying files during the run.
run: npm run format
.github/workflows/ci.yml:10
- The pipeline currently only runs formatting and linting; consider adding a dedicated test job to execute unit or integration tests and improve overall coverage.
formatting:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.