Skip to content

feat(helm/release-chart)!: simplify chart name #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilime wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −7
Open

feat(helm/release-chart)!: simplify chart name #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/__test-action-helm-release-chart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
},
{ "path": ".image.tag", "value": "0.1.0" }
]

- name: umbrella-application
values: |
[
Expand All @@ -52,7 +53,7 @@ jobs:
with:
oci-registry: ghcr.io
oci-registry-password: ${{ github.token }}
chart: ${{ matrix.chart.name }}-test
name: ${{ matrix.chart.name }}-test
path: tests/charts/${{ matrix.chart.name }}
values: ${{ matrix.chart.values }}
tag: 0.1.0
Expand All @@ -62,7 +63,7 @@ jobs:
# yamllint disable rule:line-length
- name: Check release chart output
run: |
if [ "${{ steps.release-chart.outputs.image }}" != "ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test/ci-github-container:0.1.0" ]; then
if [ "${{ steps.release-chart.outputs.image }}" != "ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test:0.1.0" ]; then
echo "Unexpected chart image name"
exit 1
fi
Expand All @@ -72,7 +73,7 @@ jobs:
- name: Check chart status
run: |
echo ${{ github.token }} | helm registry login -u ${{ github.repository_owner }} --password-stdin ghcr.io
helm pull --version "0.1.0" oci://ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test/ci-github-container
helm pull --version "0.1.0" oci://ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test
env:
HELM_EXPERIMENTAL_OCI: "1"
# yamllint enable rule:line-length
9 changes: 5 additions & 4 deletions actions/helm/release-chart/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ inputs:
OCI registry password.
See https://github.com/appany/helm-oci-chart-releaser#usage.
default: ${{ github.token }}
chart:
description: "Chart name to release"
name:
description: "Chart repository name to release"
required: true
path:
description: "Path to the chart to release"
Expand Down Expand Up @@ -329,9 +329,10 @@ runs:
- id: chart-releaser
uses: appany/helm-oci-chart-releaser@d94988c92bed2e09c6113981f15f8bb495d10943 # v0.5.0
with:
name: ${{ github.event.repository.name }}
repository: ${{ github.repository }}/charts/${{ inputs.chart }}
name: ${{ inputs.name }}
repository: ${{ github.repository }}/charts
tag: ${{ inputs.tag }}
app_version: ${{ inputs.tag }}
path: ${{ inputs.path }}
registry: ${{ inputs.oci-registry }}
registry_username: ${{ inputs.oci-registry-username }}
Expand Down
Loading