Fix intrinsicContentSize dependence on custom images. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix custom images were scaled to match fixed 44 point height.
Author
|
Probably it's a bad idea, because a tappable area may become less than 44 points. So there should be other solution for custom sized "stars" |
…l custom images. Now custom images won't scale if size of view is bigger than side of image
Author
|
hsousa
requested changes
Nov 5, 2016
Owner
hsousa
left a comment
hsousa
left a comment
There was a problem hiding this comment.
Sorry for only looking at this now! 😞
Code overall LGTM, just have some minor tweaks and should be good to go!
| - (CGSize)intrinsicContentSize { | ||
| CGFloat height = 44.f; | ||
| return CGSizeMake(_maximumValue * height + (_maximumValue-1) * _spacing, height); | ||
| CGFloat imageSide = self.emptyStarImage.size.height; |
Owner
There was a problem hiding this comment.
Total nitpick here, but could we call this imageHeight?
| CGFloat availableWidth = rect.size.width - (_spacing * (_maximumValue - 1)) - 2; | ||
| CGFloat cellWidth = (availableWidth / _maximumValue); | ||
| CGFloat starSide = (cellWidth <= rect.size.height) ? cellWidth : rect.size.height; | ||
| if (self.emptyStarImage) starSide = self.emptyStarImage.size.height; |
Owner
There was a problem hiding this comment.
We should rely on self.shouldUseImages for this for consistency.
Owner
|
Oh, forgot to mention in the review but: Thanks for this! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix custom images were scaled to match fixed 44 point height.
Now
intrinsicContentSizedepends on size of custom image to prevent image scaling.Hi. I hope I don't miss anything, but it works for me.