Improve scenario prompt error messages HUD-522 #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantzr1
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ryantzr1
force-pushed
the
fix/scenario-prompt-error-message
branch
2 times, most recently
from
0d41a10 to
3d3733c
Compare
ryantzr1
had a problem deploying
to
pre-release
GitHub Actions
Failure
ryantzr1
had a problem deploying
to
pre-release
GitHub Actions
Failure
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ryantzr1
had a problem deploying
to
pre-release
GitHub Actions
Failure
- Add context-aware errors in MCPAgent when ctx.prompt is not set - Show available scenarios when requested scenario is not found - Handle malformed and empty scenario responses with clear messages
ryantzr1
force-pushed
the
fix/scenario-prompt-error-message
branch
from
3d3733c to
013eeae
Compare
ryantzr1
had a problem deploying
to
pre-release
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Enhances scenario prompt error handling/validation, clarifies agent errors for missing prompts, and adds robust cleanup on eval context setup failure.
hud/environment/scenarios.py):get_promptresponses: raise on empty messages, malformed content, or non-string content.hud/agents/base.py):ctx.promptis missing, with targeted error messages.hud/eval/context.py):__aenter__with cleanup on failure, resetting context vars and disconnecting the environment before re-raising.Written by Cursor Bugbot for commit 013eeae. This will update automatically on new commits. Configure here.