Skip to content

No more string tags #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
inducer merged 21 commits into from
Mar 15, 2021
Merged

No more string tags #245

inducer merged 21 commits into from
Mar 15, 2021

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Mar 8, 2021 •
edited
Loading

@inducer inducer requested a review from kaushikcfd March 8, 2021 00:04
@inducer inducer marked this pull request as draft March 8, 2021 00:43
kaushikcfd
kaushikcfd reviewed Mar 8, 2021
View reviewed changes
kaushikcfd
kaushikcfd requested changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I like the example use-case through UseStreamingStore tag.

Base automatically changed from master to main March 8, 2021 05:10
@inducer inducer mentioned this pull request Mar 8, 2021
Merged
@inducer inducer changed the title Normalize Instruction.tags to use pytools.tag No more string tags Mar 11, 2021
@inducer inducer marked this pull request as ready for review March 12, 2021 01:35
@inducer inducer requested a review from kaushikcfd March 12, 2021 01:35
kaushikcfd
kaushikcfd approved these changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor concern, otherwise LGTM. Thanks!

@kaushikcfd
Copy link
Collaborator

kaushikcfd commented Mar 15, 2021

Good to go from my end.

@inducer inducer mentioned this pull request Mar 15, 2021
Open
@inducer
Copy link
Owner Author

inducer commented Mar 15, 2021

Thanks for taking a look, and sorry about the nag!

@inducer inducer merged commit e21e8f8 into main Mar 15, 2021
@inducer inducer deleted the pytools-tag-for-instruction branch March 15, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaushikcfd kaushikcfd kaushikcfd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inducer @kaushikcfd