fix: PHP 8.4 deprecation: remove all implicit nullable arguments #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murrant
changed the title
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage 75.09% 75.09%
- Complexity 437 455 +18
=========================================
Files 25 25
Lines 1104 1104
=========================================
Hits 829 829
Misses 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Nullable types were added in PHP 7.1. The minimum PHP version for this project is PHP 7.2. There is no effect. |
Fixes an issue with PHP8.4 where implicit nullable arguments are deprecated. Nullable types require PHP 7.1, so project PHP version minimum remains 7.2.
murrant
force-pushed
the
fix-implicit-nullable
branch
from
db83495 to
0300bb6
Compare
Contributor
Author
|
Also, FYI, your php-cs-fixer is too old to implement nullable_type_declaration_for_default_null_value. I suggest updating your tools. |
|
ping @bednar |
bednar
approved these changes
Jun 24, 2025
|
@bednar could we get a new release for this? 🙏 |
Contributor
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
Proposed Changes
Fixes an issue with PHP8.4 where implicit nullable arguments are deprecated. Nullable types require PHP 7.1, so project PHP version minimum remains 7.2.
Checklist
make testcompletes successfully