Skip to content

Conversation

@tfrommen
Copy link
Member

@tfrommen tfrommen commented Jan 24, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR migrates the codebase from the Inpsyde PHP_CodeSniffer standard to the new Syde PHP Coding Standards, syde/phpcs.

What is the current behavior? (You can also link to an open issue here)

The PHP_CodeSniffer setup is using the Inpsyde coding standard.

What is the new behavior (if this is a feature change)?

syde/phpcs is being used, and the code was adapted to the new sniffs.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@tfrommen tfrommen self-assigned this Jan 24, 2025
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.08%. Comparing base (c1f999e) to head (657b70d).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/Properties/LibraryProperties.php 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage     98.54%   98.08%   -0.47%     
- Complexity      251      253       +2     
============================================
  Files            10       10              
  Lines           620      627       +7     
============================================
+ Hits            611      615       +4     
- Misses            9       12       +3     
Flag Coverage Δ
unittests 98.08% <76.92%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tfrommen tfrommen marked this pull request as ready for review March 7, 2025 10:17
@tfrommen tfrommen requested a review from Chrico March 7, 2025 10:17
@tfrommen tfrommen merged commit 83d7468 into master Mar 7, 2025
62 of 64 checks passed
@tfrommen tfrommen deleted the syde-phpcs branch March 7, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants