Skip to content

Conversation

@abhilash-sivan
Copy link
Contributor

This change is a prerequisite for #2167

Corrected the error message properly in one of db2 test

@abhilash-sivan abhilash-sivan marked this pull request as ready for review November 26, 2025 17:44
@abhilash-sivan abhilash-sivan requested a review from a team as a code owner November 26, 2025 17:44
@kirrg001
Copy link
Contributor

Context:

With the refactoring in #2167, the data error property is always the error message or the error code - we no longer use the stack. The stack is always assigned to span.stack as discussed in the community.

But error.message does not contain the error type name anymore.

TypeError: "x" is not a function (stack) vs "x" is not a function (message).

We discussed that we keep the format and use error.name: error.message.

Closing PR. We discussed that we will keep the original error format, because 1) non breaking 2) less work 3) better to read for the customer.

@kirrg001 kirrg001 closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants