feat: added support for @confluentinc/kafka-javascript #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
feat-otel-confl-kaf
branch
from
b494aa5 to
702163b
Compare
kirrg001
added a commit
that referenced
this pull request
Dec 29, 2025
refs #2221 - we had no esm app for the Otel integration - proofed that it works
kirrg001
force-pushed
the
feat-otel-confl-kaf
branch
from
eb22ada to
3041691
Compare
kirrg001
commented
Dec 29, 2025
| const globalAgent = require('../../globalAgent'); | ||
| const DELAY_TIMEOUT_IN_MS = 500; | ||
| const mochaSuiteFn = supportedVersion(process.versions.node) ? describe : describe.skip; | ||
| const agentControls = globalAgent.instance; |
Contributor
Author
There was a problem hiding this comment.
globalAgent.setUpCleanUpHooks();
const agentControls = globalAgent.instance;
Was defined in all test describes. Optimized. Can extract to main before merge.
kirrg001
commented
Dec 29, 2025
| }, | ||
| "homepage": "https://github.com/instana/nodejs/blob/main/packages/core/README.md", | ||
| "dependencies": { | ||
| "@drazke/instrumentation-confluent-kafka-javascript": "https://github.com/kirrg001/instrumentation-confluent-kafka-javascript/archive/e75f8d34dd235133cc55774120cb302a539cb599.tar.gz", |
Contributor
Author
There was a problem hiding this comment.
Need to figure out before merge. Native ESM support did not work. Had to fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-66145
@confluentinc/kafka-javascriptworks out of the box, because we have support for kafkajs and rdkafka [does not work] - see https://github.com/confluentinc/confluent-kafka-javascript/blob/master/LICENSE.kafkajs